Separate client and environment settings - #4567
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
vouch:unvouched
![macroscopeapp[bot]](https://avatars.githubusercontent.com/in/900172?s=60&v=4){kind=small}
ApprovabilityVerdict: Approved This PR reorganizes existing settings into 'client' and 'environment' categories with no new functionality or runtime behavior changes - purely UI restructuring with conditional rendering and navigation grouping. You can customize Macroscope's approvability policy. Learn more. |
… in the UI) # Conflicts: # apps/web/src/components/settings/SettingsPanels.tsx
# Conflicts: # apps/web/src/components/settings/SettingsPanels.tsx
39c0a87 to
69a4878
Compare
Dismissing prior approval to re-evaluate 69a4878
69a4878 to
433b42a
Compare
1 participant
What Changed
/settings/generaland environment settings at/settings/environment.Why
Settings that follow the graphical client and settings that configure the connected execution environment currently appear together, obscuring where changes apply. Making ownership explicit supports first-class remote environments and complements #4559 and #4564.
UI Changes
Before: one flat settings navigation and a General page mixing client preferences with environment configuration.
After: labeled Client and Environment navigation groups with separate General pages. The affected flows were verified in an authenticated web client; the preview screenshot/recording endpoint failed during capture, so no reliable artifact is attached.
Checklist
Verification
vp test run src/components/settings/SettingsSidebarNav.test.ts --project unitvp linton the six affected filesvp buildinapps/weborigin/mainNote
Low Risk
Mostly UI routing and conditional rendering; no auth or persistence model changes beyond which keys restore-defaults touches per page.
Overview
Settings navigation is now grouped under Client and Environment, and the old mixed General page is split into two routes.
Client (
/settings/general) keeps UI and app preferences (theme, glass opacity, sidebar, confirmations, etc.) plus About. Environment (/settings/environment) holds execution-related options (streaming, provider checks, new-thread defaults, text generation model) and moves Diagnostics off the client General page.useSettingsRestoretakes anownershipargument so Restore defaults only lists and resets settings for the active panel, on both General pages. A unit test locks in the nav group → route mapping.Reviewed by Cursor Bugbot for commit 433b42a. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Separate client and environment settings into distinct panels in the settings sidebar
/settings/environmentroute that renders anEnvironmentSettingsPanel, splitting settings that belong to the environment (streaming, provider checks, git, model selection) away from client settings (theme, UI, confirmations).SETTINGS_NAV_ITEMSwithSETTINGS_NAV_GROUPSinSettingsSidebarNav.tsx, grouping nav items under labeled "Client" and "Environment" sections.useSettingsRestoreto accept anownershipargument so the "Restore Defaults" button resets only the settings belonging to the current panel's scope.Macroscope summarized 433b42a.